Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] : Fix e2e Flakes #658

Merged
merged 3 commits into from
Oct 6, 2023
Merged

[Test] : Fix e2e Flakes #658

merged 3 commits into from
Oct 6, 2023

Conversation

drivebyer
Copy link
Collaborator

Description

➜  redis-operator git:(fix-e2e) kubectl kuttl test ./tests/e2e/v1beta2 --config ./tests/_config/kuttl-test.yaml --timeout 10m
Error: invalid argument "10m" for "--timeout" flag: strconv.ParseInt: parsing "10m": invalid syntax

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer requested a review from shubham-cmyk October 6, 2023 03:58
@drivebyer drivebyer added the documentation Improvements or additions to documentation label Oct 6, 2023
shubham-cmyk
shubham-cmyk approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit 667ceae into OT-CONTAINER-KIT:master Oct 6, 2023
13 checks passed
@shubham-cmyk
Copy link
Member

part of #656

@shubham-cmyk shubham-cmyk changed the title Fix e2e test [Test] : Fix e2e Flakes Oct 6, 2023
@drivebyer drivebyer deleted the fix-e2e branch October 6, 2023 12:09
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @shubham-cmyk @mattrobinsonsre
Fix e2e test (OT-CONTAINER-KIT#658)
7ac9ab2 
* fix kuttl timeout unit to second

Signed-off-by: drivebyer <[email protected]>

* fix assert rediscluster version

Signed-off-by: drivebyer <[email protected]>

* Update readme.md

---------

Signed-off-by: drivebyer <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drivebyer @shubham-cmyk